Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form Segment] Form group of segments lost rounded corner when loading #628

Closed
ko2in opened this issue Apr 5, 2019 · 1 comment
Closed
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Milestone

Comments

@ko2in
Copy link
Member

ko2in commented Apr 5, 2019

Bug Report

If the group of segments is form and it has CSS class name loading, it lost the rounded corner.

Steps to reproduce

  1. Create the form with class name ui form segments.
  2. Add the form fields within each ui segment container.
  3. Manipulate the form to put loading state. Or add class name loading to ui form segments.

Expected result

The segments should keep rounded corners.

Actual result

The rounded corners become square until the class name loading is removed.

Testcase

Open https://jsfiddle.net/mgfLs0e1/, and click the submit button to reproduce.

Screenshot

FomanticUI-Segments

Version

2.7.4

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS labels Apr 5, 2019
douglasg14b added a commit to douglasg14b/Fomantic-UI that referenced this issue Apr 5, 2019
@lubber-de
Copy link
Member

Fixed by #629

@lubber-de lubber-de added this to the 2.7.5 milestone Apr 5, 2019
@lubber-de lubber-de added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Apr 8, 2019
exoego pushed a commit to exoego/Fomantic-UI that referenced this issue Apr 30, 2019
The ::before `.loader` pseudo-element did not have segment rounded corners on a `.segments.form`. Added those.

Closes fomantic#628
@y0hami y0hami closed this as completed in 5745cf7 May 16, 2019
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

No branches or pull requests

2 participants