Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form] Show/hide message depending on field state #1124

Closed
exoego opened this issue Oct 25, 2019 · 3 comments
Closed

[Form] Show/hide message depending on field state #1124

exoego opened this issue Oct 25, 2019 · 3 comments
Assignees
@exoego
Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Milestone
2.8.1

Comments

@exoego
Copy link
Contributor

exoego commented Oct 25, 2019 •
edited
Loading

Feature Request

Description

.ui.message.{STATE} should be shown when the parent .field has .{STATE} class, otherwise should be hidden, as similar to .ui.form.{STATE} do so.

I think this is useful to control visibility of field-level message depending on field state.

Testcase

Current:
https://jsfiddle.net/tsL6me0x/

Expected:
https://jsfiddle.net/u0psevtw/

Screenshot

image

Related Issue

#1097
@exoego
Copy link
Contributor Author

exoego commented Oct 25, 2019 •
edited
Loading

I will address this in PR #1098 or subsequent PR if this suggestion is fine to go.

@exoego exoego added type/feat Any feature requests or improvements lang/css Anything involving CSS labels Oct 25, 2019
@exoego exoego self-assigned this Oct 25, 2019
@lubber-de
Copy link
Member

As nobody reviewed your PR so far (i try to do it today), i think this addition could be implemented directly in #1098

@exoego exoego mentioned this issue Oct 25, 2019
Merged
3 tasks
@exoego
Copy link
Contributor Author

exoego commented Oct 25, 2019 •
edited
Loading

Thanks, added in PR #1098 d57042d

@lubber-de lubber-de added the state/has-pr An issue which has a related PR open label Oct 29, 2019
@lubber-de lubber-de added this to the 2.8.0 milestone Oct 29, 2019
y0hami pushed a commit that referenced this issue Nov 5, 2019
feat(form): generalize state variations for field
5b7e53c 
Add info state variation to form element (all other 3 are already implemented).
Add info, success and warning state variations to field element, input element and dropdown element.
Show/hide .ui.message.{STATE} depending on field-state (addresses #1124)

Closes #1097 #1124
@y0hami y0hami added tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed state/has-pr An issue which has a related PR open labels Nov 5, 2019
@y0hami y0hami closed this as completed Nov 14, 2019
@y0hami y0hami removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@exoego exoego

Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.8.1
Development

No branches or pull requests
3 participants
@exoego @y0hami @lubber-de