feat(chore): remove deprecated features

This PR removes deprecated features which the current docs already told loadUiOverrides() mixin in theme.less (if needed replace by @import (multiple, optional) "../../overrides.less"; form validation empty (use notEmpty instead) checkbox onEnabled and onDisabled were removed (typo, use onEnable and onDisable instead) page grid -> use grid container instead
fomantic · Mar 7, 2025 · fcf090f · fcf090f
1 parent 27e6218
commit fcf090f
Show file tree

Hide file tree

Showing 8 changed files with 1 addition and 126 deletions.
diff --git a/src/definitions/behaviors/form.js b/src/definitions/behaviors/form.js
@@ -1843,11 +1843,6 @@
                 return !(value === undefined || value === '' || (Array.isArray(value) && value.length === 0));
             },
 
-            /* Deprecated */
-            empty: function (value) {
-                return $.fn.form.settings.rules.notEmpty(value);
-            },
-
             // checkbox checked
             checked: function () {
                 return $(this).filter(':checked').length > 0;

diff --git a/src/definitions/collections/grid.less b/src/definitions/collections/grid.less
@@ -160,58 +160,6 @@
            Variations
 *******************************/
 
-& when (@variationGridPage) {
-    /* -----------------------
-           Page Grid
-    ------------------------- */
-
-    @media only screen and (max-width: @largestMobileScreen) {
-        .ui.page.grid {
-            width: @mobileWidth;
-            padding-left: @mobileGutter;
-            padding-right: @mobileGutter;
-            margin-left: 0;
-            margin-right: 0;
-        }
-    }
-    @media only screen and (min-width: @tabletBreakpoint) and (max-width: @largestTabletScreen) {
-        .ui.page.grid {
-            width: @tabletWidth;
-            margin-left: @tabletMargin;
-            margin-right: @tabletMargin;
-            padding-left: @tabletGutter;
-            padding-right: @tabletGutter;
-        }
-    }
-    @media only screen and (min-width: @computerBreakpoint) and (max-width: @largestSmallMonitor) {
-        .ui.page.grid {
-            width: @computerWidth;
-            margin-left: @computerMargin;
-            margin-right: @computerMargin;
-            padding-left: @computerGutter;
-            padding-right: @computerGutter;
-        }
-    }
-    @media only screen and (min-width: @largeMonitorBreakpoint) and (max-width: @largestLargeMonitor) {
-        .ui.page.grid {
-            width: @largeMonitorWidth;
-            margin-left: @largeMonitorMargin;
-            margin-right: @largeMonitorMargin;
-            padding-left: @largeMonitorGutter;
-            padding-right: @largeMonitorGutter;
-        }
-    }
-    @media only screen and (min-width: @widescreenMonitorBreakpoint) {
-        .ui.page.grid {
-            width: @widescreenMonitorWidth;
-            margin-left: @widescreenMargin;
-            margin-right: @widescreenMargin;
-            padding-left: @widescreenMonitorGutter;
-            padding-right: @widescreenMonitorGutter;
-        }
-    }
-}
-
 /* -------------------
      Column Count
 -------------------- */
@@ -338,13 +286,6 @@
     width: @sixteenColumn !important;
 }
 
-& when (@variationGridCelled) and (@variationGridPage) {
-    /* Celled Page */
-    .ui.celled.page.grid {
-        box-shadow: none;
-    }
-}
-
 & when (@variationGridWide) {
     /* -------------------
         Column Width
@@ -1724,8 +1665,7 @@
         }
 
         /* Don't pad inside segment or nested grid */
-        .ui.grid .ui.stackable.grid,
-        .ui.segment@{notVertical} .ui.stackable.page.grid {
+        .ui.grid .ui.stackable.grid {
             margin-left: -(@stackableGutter / 2);
             margin-right: -(@stackableGutter / 2);
         }

diff --git a/src/definitions/elements/segment.less b/src/definitions/elements/segment.less
@@ -94,7 +94,6 @@
 }
 
 /* Grid */
-.ui.page.grid.segment,
 .ui.grid > .row > .ui.segment.column,
 .ui.grid > .ui.segment.column {
     padding-top: @pageGridMargin;

diff --git a/src/definitions/modules/checkbox.js b/src/definitions/modules/checkbox.js
@@ -333,8 +333,6 @@
                     module.set.enabled();
                     if (!module.should.ignoreCallbacks()) {
                         settings.onEnable.call(input);
-                        // preserve legacy callbacks
-                        settings.onEnabled.call(input);
                     }
                 },
 
@@ -348,8 +346,6 @@
                     module.set.disabled();
                     if (!module.should.ignoreCallbacks()) {
                         settings.onDisable.call(input);
-                        // preserve legacy callbacks
-                        settings.onDisabled.call(input);
                     }
                 },
 
@@ -859,10 +855,6 @@
         onEnable: function () {},
         onDisable: function () {},
 
-        // preserve misspelled callbacks (will be removed in 3.0)
-        onEnabled: function () {},
-        onDisabled: function () {},
-
         className: {
             checked: 'checked',
             indeterminate: 'indeterminate',

diff --git a/src/theme.less b/src/theme.less
@@ -75,16 +75,3 @@
         });
     }
 }
-
-/* ------------------
-     Overrides
-------------------- */
-
-// Keep empty mixin in case of custom components using it so they dont break
-.loadUIOverrides() {
-    /* loadUIOverrides mixin is deprecated and will be removed in 2.10.0
-       Replace mixin call by
-          @import (multiple, optional) "../../overrides.less";
-       instead
-    */
-}
diff --git a/src/themes/default/collections/grid.variables b/src/themes/default/collections/grid.variables
@@ -86,33 +86,3 @@
 @veryCompactRowSpacing: (@compactRowSpacing / 2);
 @veryCompactCelledRelaxedPadding: (@compactCelledRelaxedPadding / 2);
 @veryCompactCelledVeryRelaxedPadding: (@compactCelledVeryRelaxedPadding / 2);
-
-/*******************************
-             Legacy
-*******************************/
-
-/* --------------
-     Page
---------------- */
-
-/* Legacy (DO NOT USE)
- */
-@mobileWidth: auto;
-@mobileMargin: 0;
-@mobileGutter: 0;
-
-@tabletWidth: auto;
-@tabletMargin: 0;
-@tabletGutter: 2em;
-
-@computerWidth: auto;
-@computerMargin: 0;
-@computerGutter: 3%;
-
-@largeMonitorWidth: auto;
-@largeMonitorMargin: 0;
-@largeMonitorGutter: 15%;
-
-@widescreenMonitorWidth: auto;
-@widescreenMargin: 0;
-@widescreenMonitorGutter: 23%;
diff --git a/src/themes/default/globals/variation.variables b/src/themes/default/globals/variation.variables
@@ -293,7 +293,6 @@
 
 /* Grid */
 @variationGridInverted: true;
-@variationGridPage: true;
 @variationGridCelled: true;
 @variationGridCentered: true;
 @variationGridRelaxed: true;

diff --git a/types/fomantic-ui-form.d.ts b/types/fomantic-ui-form.d.ts
@@ -444,12 +444,6 @@ declare namespace FomanticUI {
                  */
                 minValue: string;
 
-                /**
-                 * @default '{name} must have a value'
-                 * @deprecated Use notEmpty instead
-                 */
-                empty: string;
-
                 /**
                  * @default '{name} must have a value'
                  */
@@ -585,7 +579,6 @@ declare namespace FomanticUI {
             }
 
             interface Rules {
-                empty(value: unknown): boolean;
                 notEmpty(value: unknown): boolean;
                 checked(): boolean;
                 email(value: unknown): boolean;