Skip to content

Commit

Permalink
fix(deps): remove re2 and url-regex through rework-import
Browse files Browse the repository at this point in the history
I published a new version of fomantic/rework-import (through gulp-concat-css) which gets rid of re2 and url-regex(-safe) dependency.
The only need was to check a possible prototcol inside the import string. It does not matter if the whole URL is valid, as rework-import only needs to know if the import is a local file or not. This logic was already the case in 2.0 of the original rework-import, so basically there never was a need to switch to a separate package just for that check.

By doing all of this, fomantic does not need re2 dependency anymore which itself needs an installed python instance which especially on windows is not available by default.
  • Loading branch information
lubber-de authored Feb 8, 2025
1 parent 7f5f82a commit c6df31f
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 472 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"gulp-clean-css": "^4.3.0",
"gulp-clone": "^2.0.1",
"gulp-concat": "^2.6.1",
"@fomantic/gulp-concat-css": "^3.2.1",
"@fomantic/gulp-concat-css": "^3.3.0",
"@fomantic/gulp-concat-filenames": "^1.2.1",
"@fomantic/gulp-dedupe": "^0.0.3",
"gulp-flatten": "^0.4.0",
Expand Down
Loading

0 comments on commit c6df31f

Please sign in to comment.