Skip to content

Commit

Permalink
feat(header): seamless attached variant
Browse files Browse the repository at this point in the history
The attached header doesn't support the seamless variant like the segment element which results in showing the border between the header and the attached element below.

This PR allows to have the attached header element with seamless variant that allows to remove the bottom border when it attaches with the another segment below.
  • Loading branch information
ko2in authored Sep 22, 2023
1 parent 3ada1e1 commit b198514
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/definitions/elements/header.less
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,11 @@
.ui.bottom.attached.header {
border-radius: 0 0 @attachedBorderRadius @attachedBorderRadius;
}
& when (@variationHeaderSeamless) {
.ui.seamless.attached:not(.bottom).header {
border-bottom: none;
}
}

/* Attached Sizes */
.ui.attached.header:not(h1):not(h2):not(h3):not(h4):not(h5):not(h6) {
Expand Down
1 change: 1 addition & 0 deletions src/themes/default/globals/variation.variables
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@
@variationHeaderDividing: true;
@variationHeaderBlock: true;
@variationHeaderAttached: true;
@variationHeaderSeamless: true;
@variationHeaderTags: h1, h2, h3, h4, h5, h6;
@variationHeaderSizes: @variationAllSizes;
@variationHeaderColors: @variationAllColors;
Expand Down

0 comments on commit b198514

Please sign in to comment.