Skip to content

Commit

Permalink
feat(chore): remove vendor checks
Browse files Browse the repository at this point in the history 
Thir PR removes some vendor checks as we are not supporting very old browsers anymore where such checks were necessary
  • Loading branch information
@lubber-de
lubber-de authored Jan 30, 2023
1 parent 5b497e3 commit 8838309
Show file tree
Hide file tree
Showing 14 changed files with 54 additions and 192 deletions.
4 changes: 2 additions & 2 deletions src/definitions/behaviors/form.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -888,7 +888,7 @@
.html(settings.templates.prompt(errors))
;
if (!promptExists) {
if (settings.transition && module.can.useElement('transition') && $module.transition('is supported')) {
if (settings.transition && module.can.useElement('transition')) {
module.verbose('Displaying error with css transition', settings.transition);
$prompt.transition(settings.transition + ' in', settings.duration);
} else {
Expand Down Expand Up @@ -984,7 +984,7 @@
;
if (settings.inline && $prompt.is(':visible')) {
module.verbose('Removing prompt for field', identifier);
if (settings.transition && module.can.useElement('transition') && $module.transition('is supported')) {
if (settings.transition && module.can.useElement('transition')) {
$prompt.transition(settings.transition + ' out', settings.duration, function () {
$prompt.remove();
});
Expand Down
6 changes: 3 additions & 3 deletions src/definitions/modules/accordion.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@
.addClass(className.animating)
;
if (settings.animateChildren) {
if ($.fn.transition !== undefined && $module.transition('is supported')) {
if ($.fn.transition !== undefined) {
$activeContent
.children()
.transition({
Expand Down Expand Up @@ -239,7 +239,7 @@
.addClass(className.animating)
;
if (settings.animateChildren) {
if ($.fn.transition !== undefined && $module.transition('is supported')) {
if ($.fn.transition !== undefined) {
$activeContent
.children()
.transition({
Expand Down Expand Up @@ -308,7 +308,7 @@
.stop(true, true)
;
if (settings.animateChildren) {
if ($.fn.transition !== undefined && $module.transition('is supported')) {
if ($.fn.transition !== undefined) {
$openContents
.children()
.transition({
Expand Down
4 changes: 2 additions & 2 deletions src/definitions/modules/dimmer.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@
callback = isFunction(callback)
? callback
: function () {};
if (settings.useCSS && $.fn.transition !== undefined && $dimmer.transition('is supported')) {
if (settings.useCSS && $.fn.transition !== undefined) {
if (settings.useFlex) {
module.debug('Using flex dimmer');
module.remove.legacy();
Expand Down Expand Up @@ -288,7 +288,7 @@
callback = isFunction(callback)
? callback
: function () {};
if (settings.useCSS && $.fn.transition !== undefined && $dimmer.transition('is supported')) {
if (settings.useCSS && $.fn.transition !== undefined) {
module.verbose('Hiding dimmer with css');
$dimmer
.transition({
Expand Down
4 changes: 2 additions & 2 deletions src/definitions/modules/dropdown.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3637,7 +3637,7 @@
displayType: module.get.displayType(),
}).transition('show');
callback.call(element);
} else if (module.can.useElement('transition') && $module.transition('is supported')) {
} else if (module.can.useElement('transition')) {
$currentMenu
.transition({
animation: transition + ' in',
Expand Down Expand Up @@ -3679,7 +3679,7 @@
displayType: module.get.displayType(),
}).transition('hide');
callback.call(element);
} else if ($.fn.transition !== undefined && $module.transition('is supported')) {
} else if ($.fn.transition !== undefined) {
$currentMenu
.transition({
animation: transition + ' out',
Expand Down
2 changes: 1 addition & 1 deletion src/definitions/modules/embed.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,7 @@
return ''
+ '<iframe src="' + deQuote(src) + '"'
+ ' width="100%" height="100%"'
+ ' webkitAllowFullScreen mozallowfullscreen allowFullScreen></iframe>';
+ ' msallowFullScreen allowFullScreen></iframe>';
},
placeholder: function (image, icon) {
var
Expand Down
32 changes: 6 additions & 26 deletions src/definitions/modules/flyout.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@
observer,
observeAttributes = false,
currentScroll,
transitionEvent,

module
;
Expand Down Expand Up @@ -146,8 +145,6 @@
});
}

transitionEvent = module.get.transitionEvent();

// avoids locking rendering if initialized in onReady
if (settings.delaySetup) {
requestAnimationFrame(module.setup.layout);
Expand Down Expand Up @@ -757,13 +754,13 @@
};
transitionEnd = function (event) {
if (event.target === $module[0]) {
$module.off(transitionEvent + elementNamespace, transitionEnd);
$module.off('transitionend' + elementNamespace, transitionEnd);
module.remove.animating();
callback.call(element);
}
};
$module.off(transitionEvent + elementNamespace);
$module.on(transitionEvent + elementNamespace, transitionEnd);
$module.off('transitionend' + elementNamespace);
$module.on('transitionend' + elementNamespace, transitionEnd);
requestAnimationFrame(animate);
if (settings.dimPage && !module.othersVisible()) {
requestAnimationFrame(dim);
Expand Down Expand Up @@ -798,7 +795,7 @@
};
transitionEnd = function (event) {
if (event.target === $module[0]) {
$module.off(transitionEvent + elementNamespace, transitionEnd);
$module.off('transitionend' + elementNamespace, transitionEnd);
module.remove.animating();
module.remove.closing();
module.remove.overlay();
Expand All @@ -812,8 +809,8 @@
callback.call(element);
}
};
$module.off(transitionEvent + elementNamespace);
$module.on(transitionEvent + elementNamespace, transitionEnd);
$module.off('transitionend' + elementNamespace);
$module.on('transitionend' + elementNamespace, transitionEnd);
requestAnimationFrame(animate);
},

Expand Down Expand Up @@ -981,23 +978,6 @@

return className.left;
},
transitionEvent: function () {
var
element = document.createElement('element'),
transitions = {
transition: 'transitionend',
OTransition: 'oTransitionEnd',
MozTransition: 'transitionend',
WebkitTransition: 'webkitTransitionEnd',
},
transition
;
for (transition in transitions) {
if (element.style[transition] !== undefined) {
return transitions[transition];
}
}
},
id: function () {
return id;
},
Expand Down
8 changes: 3 additions & 5 deletions src/definitions/modules/modal.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@
$module.detach().appendTo($dimmer);
}
}
if (settings.transition && $.fn.transition !== undefined && $module.transition('is supported')) {
if (settings.transition && $.fn.transition !== undefined) {
module.debug('Showing modal with css animations');
module.set.observeAttributes(false);
$module
Expand Down Expand Up @@ -656,7 +656,7 @@

if (module.is.animating() || module.is.active()) {
module.debug('Hiding modal');
if (settings.transition && $.fn.transition !== undefined && $module.transition('is supported')) {
if (settings.transition && $.fn.transition !== undefined) {
module.remove.active();
module.set.observeAttributes(false);
$module
Expand Down Expand Up @@ -994,9 +994,7 @@
return module.cache.isIE;
},
animating: function () {
return $module.transition('is supported')
? $module.transition('is animating')
: $module.is(':visible');
return $module.transition('is animating');
},
scrolling: function () {
return $dimmable.hasClass(className.scrolling);
Expand Down
4 changes: 2 additions & 2 deletions src/definitions/modules/popup.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@
animate: {
show: function (callback) {
callback = isFunction(callback) ? callback : function () {};
if (settings.transition && module.can.useElement('transition') && $module.transition('is supported')) {
if (settings.transition && module.can.useElement('transition')) {
module.set.visible();
$popup
.transition({
Expand All @@ -436,7 +436,7 @@
hide: function (callback) {
callback = isFunction(callback) ? callback : function () {};
module.debug('Hiding pop-up');
if (settings.transition && $.fn.transition !== undefined && $module.transition('is supported')) {
if (settings.transition && $.fn.transition !== undefined) {
$popup
.transition({
animation: (settings.transition.hideMethod || settings.transition) + ' out',
Expand Down
30 changes: 2 additions & 28 deletions src/definitions/modules/progress.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@
instance = $module.data(moduleNamespace),

animating = false,
transitionEnd,
module
;
module = {
Expand Down Expand Up @@ -115,7 +114,6 @@

initialize: function () {
module.set.duration();
module.set.transitionEvent();
module.debug(element);

module.read.metadata();
Expand Down Expand Up @@ -195,17 +193,14 @@

bind: {
transitionEnd: function (callback) {
var
transitionEnd = module.get.transitionEnd()
;
$bars
.one(transitionEnd + eventNamespace, function (event) {
.one('transitionend' + eventNamespace, function (event) {
clearTimeout(module.failSafeTimer);
callback.call(this, event);
})
;
module.failSafeTimer = setTimeout(function () {
$bars.triggerHandler(transitionEnd);
$bars.triggerHandler('transitionend');
}, settings.duration + settings.failSafeDelay);
module.verbose('Adding fail safe timer', module.timer);
},
Expand Down Expand Up @@ -330,24 +325,6 @@
: value;
},

transitionEnd: function () {
var
element = document.createElement('element'),
transitions = {
transition: 'transitionend',
OTransition: 'oTransitionEnd',
MozTransition: 'transitionend',
WebkitTransition: 'webkitTransitionEnd',
},
transition
;
for (transition in transitions) {
if (element.style[transition] !== undefined) {
return transitions[transition];
}
}
},

// gets current displayed percentage (if animating values this is the intermediary value)
displayPercent: function (index) {
var
Expand Down Expand Up @@ -687,9 +664,6 @@
settings.onError.call(element, module.value, module.total);
});
},
transitionEvent: function () {
transitionEnd = module.get.transitionEnd();
},
total: function (totalValue) {
module.total = totalValue;
},
Expand Down
2 changes: 1 addition & 1 deletion src/definitions/modules/search.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@
return module.is.focused() && !module.is.visible() && !module.is.empty();
},
transition: function () {
return settings.transition && $.fn.transition !== undefined && $module.transition('is supported');
return settings.transition && $.fn.transition !== undefined;
},
},

Expand Down
50 changes: 14 additions & 36 deletions src/definitions/modules/shape.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -116,33 +116,29 @@
module.set.active();
};
settings.onBeforeChange.call($nextSide[0]);
if (module.get.transitionEvent()) {
module.verbose('Starting CSS animation');
module.verbose('Starting CSS animation');
$module
.addClass(className.animating)
;
$sides
.css(propertyObject)
.one('transitionend', callback)
;
module.set.duration(settings.duration);
requestAnimationFrame(function () {
$module
.addClass(className.animating)
;
$sides
.css(propertyObject)
.one(module.get.transitionEvent(), callback)
$activeSide
.addClass(className.hidden)
;
module.set.duration(settings.duration);
requestAnimationFrame(function () {
$module
.addClass(className.animating)
;
$activeSide
.addClass(className.hidden)
;
});
} else {
callback();
}
});
},

queue: function (method) {
module.debug('Queueing animation of', method);
$sides
.one(module.get.transitionEvent(), function () {
.one('transitionend', function () {
module.debug('Executing queued animation');
setTimeout(function () {
$module.shape(method);
Expand Down Expand Up @@ -412,24 +408,6 @@
},
},

transitionEvent: function () {
var
element = document.createElement('element'),
transitions = {
transition: 'transitionend',
OTransition: 'oTransitionEnd',
MozTransition: 'transitionend',
WebkitTransition: 'webkitTransitionEnd',
},
transition
;
for (transition in transitions) {
if (element.style[transition] !== undefined) {
return transitions[transition];
}
}
},

nextSide: function () {
return $activeSide.next(selector.side).length > 0
? $activeSide.next(selector.side)
Expand Down
Loading

0 comments on commit 8838309

Please sign in to comment.