fix(chore): remove old sui v1 unsupported and undocumented code

This PR removes SUI v1.x legacy code which is not even documented since years anymore.
fomantic · Dec 27, 2022 · 1124496 · 1124496
1 parent 0ac5353
commit 1124496
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 47 deletions.
diff --git a/src/definitions/behaviors/form.js b/src/definitions/behaviors/form.js
@@ -28,7 +28,6 @@
             performance      = [],
 
             query            = arguments[0],
-            legacyParameters = arguments[1],
             methodInvoked    = typeof query === 'string',
             queryArguments   = [].slice.call(arguments, 1),
             returnedValue
@@ -572,27 +571,12 @@
                     },
                     settings: function () {
                         if ($.isPlainObject(parameters)) {
-                            var
-                                keys     = Object.keys(parameters),
-                                isLegacySettings = keys.length > 0
-                                    ? parameters[keys[0]].identifier !== undefined && parameters[keys[0]].rules !== undefined
-                                    : false
-                            ;
-                            if (isLegacySettings) {
-                                // 1.x (ducktyped)
-                                settings = $.extend(true, {}, $.fn.form.settings, legacyParameters);
-                                validation = $.extend(true, {}, $.fn.form.settings.defaults, parameters);
-                                module.error(settings.error.oldSyntax, element);
-                                module.verbose('Extending settings from legacy parameters', validation, settings);
-                            } else {
-                                // 2.x
-                                if (parameters.fields) {
-                                    parameters.fields = module.get.fieldsFromShorthand(parameters.fields);
-                                }
-                                settings = $.extend(true, {}, $.fn.form.settings, parameters);
-                                validation = $.extend(true, {}, $.fn.form.settings.defaults, settings.fields);
-                                module.verbose('Extending settings', validation, settings);
+                            if (parameters.fields) {
+                                parameters.fields = module.get.fieldsFromShorthand(parameters.fields);
                             }
+                            settings = $.extend(true, {}, $.fn.form.settings, parameters);
+                            validation = $.extend(true, {}, $.fn.form.settings.defaults, settings.fields);
+                            module.verbose('Extending settings', validation, settings);
                         } else {
                             settings = $.extend(true, {}, $.fn.form.settings);
                             validation = $.extend(true, {}, $.fn.form.settings.defaults);
@@ -1620,7 +1604,6 @@
             identifier: 'You must specify a string identifier for each field',
             method: 'The method you called is not defined.',
             noRule: 'There is no rule matching the one you specified',
-            oldSyntax: 'Starting in 2.0 forms now only take a single settings object. Validation settings converted to new syntax automatically.',
             noField: 'Field identifier {identifier} not found',
             noElement: 'This module requires ui {element}',
         },

diff --git a/src/definitions/modules/tab.js b/src/definitions/modules/tab.js
@@ -78,7 +78,6 @@
 
                 initialize: function () {
                     module.debug('Initializing tab menu item', $module);
-                    module.fix.callbacks();
                     module.determineTabs();
 
                     module.debug('Determining tabs', settings.context, $tabs);
@@ -168,24 +167,6 @@
                     }
                 },
 
-                fix: {
-                    callbacks: function () {
-                        if ($.isPlainObject(parameters) && (parameters.onTabLoad || parameters.onTabInit)) {
-                            if (parameters.onTabLoad) {
-                                parameters.onLoad = parameters.onTabLoad;
-                                delete parameters.onTabLoad;
-                                module.error(error.legacyLoad, parameters.onLoad);
-                            }
-                            if (parameters.onTabInit) {
-                                parameters.onFirstLoad = parameters.onTabInit;
-                                delete parameters.onTabInit;
-                                module.error(error.legacyInit, parameters.onFirstLoad);
-                            }
-                            settings = $.extend(true, {}, $.fn.tab.settings, parameters);
-                        }
-                    },
-                },
-
                 initializeHistory: function () {
                     module.debug('Initializing page state');
                     if ($.address === undefined) {
@@ -947,8 +928,6 @@
             noContent: 'The tab you specified is missing a content url.',
             path: 'History enabled, but no path was specified',
             recursion: 'Max recursive depth reached',
-            legacyInit: 'onTabInit has been renamed to onFirstLoad in 2.0, please adjust your code.',
-            legacyLoad: 'onTabLoad has been renamed to onLoad in 2.0. Please adjust your code',
             state: 'History requires Asual\'s Address library <https://github.com/asual/jquery-address>',
         },
 

diff --git a/src/themes/default/modules/checkbox.overrides b/src/themes/default/modules/checkbox.overrides
@@ -8,19 +8,16 @@
 }
 
 /* Checkmark */
-.ui.checkbox label::after,
-.ui.checkbox .box::after {
+.ui.checkbox label::after {
     font-family: Checkbox;
 }
 
 /* Checked */
-.ui.checkbox input:checked ~ .box::after,
 .ui.checkbox input:checked ~ label::after {
     content: "\e800";
 }
 
 /* Indeterminate */
-.ui.checkbox input:indeterminate ~ .box::after,
 .ui.checkbox input:indeterminate ~ label::after {
     font-size: 12px;
     content: "\e801";