UIU-3279 supply tenantId in all useUserTenantRoles queries #2809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supply the `tenantId` argument in all queries. It was present in the query for a user's roles, but missing from the follow-up join-query that retrieved those roles' details, and thus returned an empty list unless the selected-tenant matched that of the currently-authenticated tenant. Refs UIU-3279
Terala-Priyanka
approved these changes
Nov 26, 2024
aidynoJ
approved these changes
Nov 26, 2024
|
Terala-Priyanka
pushed a commit
that referenced
this pull request
Nov 28, 2024
Supply the `tenantId` argument in all queries. It was present in the query for a user's roles, but missing from the follow-up join-query that retrieved those roles' details, and thus returned an empty list unless the selected-tenant matched that of the currently-authenticated user. Refs UIU-3279
Terala-Priyanka
added a commit
that referenced
this pull request
Nov 29, 2024
* Show all patron notice print jobs, in correct order (#2806) We now show the top 100 patron notice print jobs, not 10. More importantly, they are now sorted correctly (reverse chronological) on the server side, so even if the list grows past 100 and so is truncated in the UI at the first hundred, they will be the _right_ (most recent) first hundred. Fixes UIU-3269. * UIU-3249 - Leverage API supported sorting of columns on pre-registrations records list. (#2808) * UIU-3279 supply tenantId in all useUserTenantRoles queries (#2809) Supply the `tenantId` argument in all queries. It was present in the query for a user's roles, but missing from the follow-up join-query that retrieved those roles' details, and thus returned an empty list unless the selected-tenant matched that of the currently-authenticated user. Refs UIU-3279 * Release v11.0.6 --------- Co-authored-by: Mike Taylor <mike@indexdata.com> Co-authored-by: Zak Burke <zburke@ebsco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supply the
tenantIdargument in all queries. It was present in the query for a user's roles, but missing from the follow-up join-query that retrieved those roles' details, and thus returned an empty list unless the selected-tenant matched that of the currently-authenticated user.Refs UIU-3279