MODWRKFLOW-46: Make compatible with spring-boot 3.4 upgrades. #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttings. The settings changed from `enabled` to access` and `enabled-by-default` to `access.default`. The `access` values are no longer boolean and are instead one of `read-only`, `none`, and `unrestricted`. I decided to use `read-only` for values that were previously `true`. see: https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.4-Release-Notes#controlling-access-to-actuator-endpoints
This is required because the `8.3.0-SNAPSHOT` is what is needed for the Spring Boot 3.4 support.
Appease this error: ``` Description: Parameter 2 of constructor in org.folio.spring.service.TenantService required a bean of type 'org.folio.spring.liquibase.FolioSpringLiquibase' that could not be found. Action: Consider defining a bean of type 'org.folio.spring.liquibase.FolioSpringLiquibase' in your configuration. ```
The `ObjectMapper` bean is provided because the `@MockitoSpyBean` no longer instantiates when there is no bean found in the way that no available or deprecated `@SpyBean` does. see: spring-projects/spring-framework#33935
rmathew1011
approved these changes
Feb 11, 2025
wwtamu
approved these changes
Feb 11, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves MODWRKFLOW-46.
The
ObjectMapperbean is provided because the@MockitoSpyBeanno longer instantiates when there is no bean found in the way that no available or deprecated@SpyBeandoes.Appease this error:
Switch
folio-spring-supportdependency to8.3.0-SNAPSHOTbecause this is needed for the Spring Boot 3.4 support. Prior versions do not work under Spring-Boot 3.4.Update the Controlling Access to Actuator Endpoints settings.
The settings changed from
enabledto accessandenabled-by-defaulttoaccess.default`.The
accessvalues are no longer boolean and are instead one ofread-only,none, andunrestricted.I decided to use
read-onlyfor values that were previouslytrue.Replace
@MockBeanand@SpyBean.@MockitoBeanandMockitoSpyBeanare the replacemenets to the deprecated or removed@MockBeanand@SpyBean.Address failing bean problems.
ObjectMapperbean is provided because the@MockitoSpyBeanno longer instantiates when there is no bean found in the way that no available or deprecated@SpyBeandoes.@MockitoSpyBeanrequires existing bean instance to spy on spring-projects/spring-framework#33935This requires the changes from Spring Module Core PR 74 for SPRNGCORE-6.