MODSOURCE-824: Endpoint /batch/parsed-records/fetch does not return deleted records #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VRohach
requested review from
RuslanLavrov,
dmytrokrutii,
JavokhirAbdullayev,
KaterynaSenchenko and
RomanChernetskyi
|
This PR should be merged only after merging: folio-org/data-import-raml-storage#315 |
dmytrokrutii
approved these changes
Nov 25, 2024
JavokhirAbdullayev
approved these changes
Nov 25, 2024
…rd-storage into MODSOURCE-824 # Conflicts: # NEWS.md
KaterynaSenchenko
approved these changes
Nov 26, 2024
RuslanLavrov
approved these changes
Nov 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The main goal is to extend POST /batch/parsed-records/fetch endpoint to be able to retrieve DELETED records.
There was added a brand new property- "includeDeleted" to the body request to include DELETED records if this set to "true".
If "includeDeleted": "false" or "includeDeleted" not exists - it will return JUST ACTUAL record.
Approach
Additional condition added to DAO based on "includeDeleted" property.
Test added.
NEWS updated.
TODOS and Open Questions
Learning
JIRA: https://folio-org.atlassian.net/browse/MODSOURCE-824