-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MODSOURCE-773: MARC Search omits suppressed from discovery records in default search. #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VRohach
changed the title
Modsource 773
MODSOURCE-773: MARC Search omits suppressed from discovery records in default search.
May 21, 2024
VRohach
requested review from
RuslanLavrov,
Aliaksandr-Fedasiuk,
KaterynaSenchenko,
JavokhirAbdullayev,
RomanChernetskyi and
Maksat-Galymzhan
May 22, 2024 13:33
This PR should be merged ONLY after folio-org/data-import-raml-storage#310 will be merged. |
KaterynaSenchenko
approved these changes
May 23, 2024
Maksat-Galymzhan
approved these changes
May 23, 2024
JavokhirAbdullayev
approved these changes
May 23, 2024
RuslanLavrov
approved these changes
May 24, 2024
…ges in tests - fixed .
…rd-storage into MODSOURCE-773
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Create an opportunity to get the response that will include all records regardless of their discovery suppress status.
Approach
Default value "false" for target field removed.
boolean change to Boolean to be able to accept null values (the same behavior as for limit/offset)
Learning
JIRA: https://folio-org.atlassian.net/browse/MODSOURCE-773