46 nova funkcionalnost f16 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ne može se kompilirati jer niti nema klase GptService.
Nema potrebe za refaktoriranjem jer je kod izrazito jednostavan.
Test se ne može kompilirati.
Napravljeno svojstvo "systemMessage" koji će biti postavljen kada se pozove metoda SetSystemMessage().
...Message, test pada jer nema te metode.
...instanca GPTRequestSender (u ovom slučaju fake)
...u konstruktoru testne klase.
...metoda SendRequest od GPTRequestSender i prima li instancu objekta GPTRequest.
Kreirana klasa GPTRequest i GPTService poziva metodu SendRequest od sučelja IGPTRequestSender.
Nema još potrebe za daljnjim refaktoriranjem.
Dodana je nova klasa GPTMessage koja sadrži "content", prema onome napisanom u testu.
...šalje li se ispravna "uloga".
Dodano je svojstvo "role" u GPTMessage i postavlja ga GPTService.
vlovric21
approved these changes
Jun 15, 2024
mmarkoovin21
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nova funkcionalnost
Kreirana je funkcionalnost: Chatbot LibrAI
On pomaže članovima knjižnice raspitati o knjižnici.
Pokreće ga se klikom na ikonicu dolje lijevo kad se korisnik prijavi kao član knjižnice:
Slike su sljedeće:
Bitno
Potrebno je unijeti vlastiti OpenAI API ključ. Nisam htio "hardkodirati" privatni ključ u kod aplikacije jer bi bio dostupan ovdje, na javno dostupnom repozitoriju.
Razvoj i testovi
Klasa GPTService kreirana je putem Test Driven Development. Ovdje su neki commitovi:
Jedinični testovi su sljedeći:
Integracijski testovi su sljedeći:
