Add default_for_az attribute to subnet
#402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks! @lanej mind taking a look as well to confirm? Thanks! |
|
LGTM (ref: http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeSubnets.html). @rzaharenkov can you rebase off master please? |
* Add new attribute `default_for_az` to `Subnet` model; * Update parsers to take into account new attribute; * Fix comments and tests for `map_public_ip_on_launch` attribute.
rzaharenkov
force-pushed
the
rz-subnet-default-for-az
branch
from
0f63344 to
d689de6
Compare
|
thanks for review, I've rebased it |
lanej
approved these changes
Oct 18, 2017
|
Thanks @rzaharenkov |
|
Thanks!
…On Wed, Oct 18, 2017 at 11:34 AM, Josh Lane ***@***.***> wrote:
Thanks @rzaharenkov <https://github.com/rzaharenkov>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#402 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAQKpiGHglvd5mxT7YcDLwR49YAteNhks5stiiPgaJpZM4P7O0h>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default_for_aztoSubnetmodel;map_public_ip_on_launchattribute.