Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Service mapper from Fog #392

Merged
merged 2 commits into from
Sep 15, 2017
Merged

Conversation

plribeiro3000
Copy link
Member

closes #390

@plribeiro3000
Copy link
Member Author

It's been a while i don't follow the AWS portion of fog anymore so i'm kind of lost on some points. 😄

While running the tests i've noticed there are some noisy puts. Are those supposed to be there?
If not i can make another PR removing them.

I've noticed also that the file CONTRIBUTORS is kind of outdated. Should i send another PR for that also?

Also, how is CHANGELOG being updated? should i add something?

cc @lanej @geemus

@lanej
Copy link
Member

lanej commented Sep 14, 2017

While running the tests i've noticed there are some noisy puts. Are those supposed to be there?
If not i can make another PR removing them.

That would be great.

I've noticed also that the file CONTRIBUTORS is kind of outdated. Should i send another PR for that also?

Yes please.

Also, how is CHANGELOG being updated? should i add something?

I've been using https://github.com/skywinder/github-changelog-generator to update the CHANGELOG automatically.

@plribeiro3000
Copy link
Member Author

@lanej Working on those PR's.

Is there something else missing here? Dunno if the broken build is related. =s

@plribeiro3000
Copy link
Member Author

@lanej See #393 and #394

@plribeiro3000
Copy link
Member Author

Also, regarding the CHANGELOG i think that's just great!

I prefer to follow keepachangelog and keep it more human readable. Just dropping this here in case you find it interesting. =)

@geemus
Copy link
Member

geemus commented Sep 15, 2017

I use osrcry to update contributors on things usually, fwiw. (it has stuff for updating license too, maybe even contributing). I made it a while back to help automate, since I seem to have a growing set of OS things to try and keep straight. I'd welcome feedback on improving it, but hope it can streamline some of this for us.

@geemus geemus merged commit 24ba637 into fog:master Sep 15, 2017
@geemus
Copy link
Member

geemus commented Sep 15, 2017

Here is osrcry link: https://github.com/geemus/osrcry

It's also a gem with a binary (which is how I actually use it).

@plribeiro3000 plribeiro3000 deleted the service_mapper branch September 15, 2017 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing file for extraction?
3 participants