Subnet #343
Merged
Subnet #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, @lanej could you review/merge when you get a chance? Thanks! |
added 3 commits
February 21, 2017 13:36
* need to return subnet id in instance mocks * subnet -> network interfaces relationship * move addresses to and from vpcs * bump compute api version to 2016-11-15 * [mock] set dnsname for instance if the vpc is setup for it
|
Thanks eugene |
|
Thanks!
…On Thu, Feb 23, 2017 at 1:35 PM, Josh Lane ***@***.***> wrote:
Thanks eugene
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#343 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAQKgMv7qdVZZbmllfrOkvcgdgeZ978ks5rfd-UgaJpZM4L9vyl>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.