-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to pass containerElements to focus-trap #179
Conversation
🦋 Changeset detectedLatest commit: afccf7d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cgood92 I appreciate the update in this repo too, ahead of the pending related focus-trap changes. That's a big help! This seems solid, just a couple of minor things. I also really appreciate you took the time to add unit and 2e2 tests! 💪
@stefcameron thank you so much for your time and consideration. This PR is now ready to go, with the new release of focus-trap. |
My pleasure! Thanks for updating it to the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could of things...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this, @cgood92, much appreciated! 🎉
@all-contributors please add @cgood92 for code, docs, examples, tests |
I've put up a pull request to add @cgood92! 🎉 |
Published in 8.2.0 |
This is WIP until the first PR is merged: focus-trap/focus-trap#217, and the dependency of focus-trap is updated.
Features and Bug Fixes
yarn changeset
locally to add one, follow prompts).This is part 2 of the PR focus-trap/focus-trap#217
Demo 1
Demo 2