Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document is not defined error after updating to 8.8.0 #482

Closed
syntactic-salt opened this issue Sep 27, 2021 · 6 comments · Fixed by #483
Closed

document is not defined error after updating to 8.8.0 #482

syntactic-salt opened this issue Sep 27, 2021 · 6 comments · Fixed by #483
Labels
bug

Comments

@syntactic-salt
Copy link

After updating to version 8.8.0 my server side rendered React application fails to render because document is not defined at render time. The referenceError points to a change in focus-trap-react.js that was introduced in PR#460.
@PabloSzx PabloSzx mentioned this issue Sep 27, 2021
Merged
@stefcameron
Copy link
Member

Ah, server side rendering. 🤦‍♂️ 😄 Thank you for letting me know. I'll try to fix this ASAP.

stefcameron added a commit that referenced this issue Sep 27, 2021
@stefcameron
[#482] Fix SSR issues when accessing document object
806b0d4 
Fixes #482
stefcameron added a commit that referenced this issue Sep 27, 2021
@stefcameron
[#482] Fix SSR issues when accessing document object
46468bc 
Fixes #482
@stefcameron stefcameron mentioned this issue Sep 27, 2021
Merged
stefcameron added a commit that referenced this issue Sep 27, 2021
@stefcameron
[#482] Fix SSR issues when accessing document object (#483)
a2806a0 
Fixes #482
@stefcameron
Copy link
Member

@all-contributors add @syntactic-salt for bug

@allcontributors allcontributors bot mentioned this issue Sep 27, 2021
Merged
@allcontributors
Copy link
Contributor

@stefcameron

I've put up a pull request to add @syntactic-salt! 🎉

@github-actions github-actions bot mentioned this issue Sep 27, 2021
Merged
@stefcameron
Copy link
Member

Fixed in v8.8.1

@syntactic-salt
Copy link
Author

Fixed in v8.8.1

Thanks for the quick fix.

@stefcameron
Copy link
Member

Fixed in v8.8.1

Thanks for the quick fix.

My pleasure!

This was referenced Sep 12, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#482] Fix SSR issues when accessing document object focus-trap/focus-trap-react
2 participants
@stefcameron @syntactic-salt