Add unit tests to Fn UI #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am planning on adding unit tests for these parsers. Seperating them out should make this easier, it keeps the files smaller and more readable, plus it keeps things more organised.
Make a start on adding Unit Tests to the repo so that we can automatically test code e.g. on pull requests.
We have recently made a start on adding Unit Tests. Run these Unit Tests as part of CircleCI so that any PRs are automatically checked for issues.
This means devs can now lint their code by running "npm run lint". This is alot easier to remember and makes it easier to change the linter should we choose to use another one in the future
rdallman
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
I've made a start at adding some unit tests to the Fn UI. I've started with the Stats Parser classes. I'd like to also mock the Fn API calls and unit test those too, but that's for another day. I've added support to CircleCI so the tests are automatically run.
I've also snuck a short hand command to make running linting easier in too:
npm run lintNotes
I've used
--loglevel silentfor thenpm installin CircleCI because it spurts out lots of errors/warnings currently (due to deprecated packages) when it's run. Cleaning all that up was on my list, but I didn't get around to it :(.How to test
My Testing
I've tested by running
npm testandnpm run test-integrationAs I've made changes to the Stats Parser classes I've also tested running functions using the UI and ensuring the charts update correctly.
Lastly, I checked CircleCI when I pushed to my fork to ensure everything was passing.