write_demangled_name supports libc++ + clang-cl #4560
Merged
+62
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FatihBAKIR
force-pushed
the
stdtest-fix
branch
from
bd541b3 to
7160892
Compare
|
@vitaut the lint/format_code task is failing but it also points out a file I did not touch. I also formatted the files locally with clang-format using the |
|
The formatting issue in |
|
As for the formatting issue in -auto normalize_msvc_abi_name(string_view abi_name_view,
- OutputIt out) -> OutputIt {
+auto normalize_msvc_abi_name(string_view abi_name_view, OutputIt out)
+ -> OutputIt { |
FatihBAKIR
force-pushed
the
stdtest-fix
branch
from
7160892 to
1f92869
Compare
The current implementation assumes whenever we're on an FMT_MSC_VERSION compiler, the standard library is MSVC's STL. However, with clang-cl we have the possibility of using LLVM libc++ instead of MSVC STL. In that scenario, the previous implementation produced the wrong demangled names for RTTI types. This patch detects the different combinations, and combines the existing demangling implementations to produce the correct names and make all tests pass on libc++ + clang-cl.
FatihBAKIR
force-pushed
the
stdtest-fix
branch
from
1f92869 to
c2abdd4
Compare
|
Thank you for the fix! |
vitaut
reviewed
Oct 9, 2025
Comment on lines
+142
to
+143
| string_view normalize_libcxx_inline_namespaces(string_view demangled_name_view, | ||
| char* begin) { |
There was a problem hiding this comment.
This function should have been inline because it is defined in the header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation assumes whenever we're on an FMT_MSC_VERSION compiler, the standard library is MSVC's STL. However, with clang-cl we have the possibility of using LLVM libc++ instead of MSVC STL. In that scenario, the previous implementation produced the wrong demangled names for RTTI types.
This patch detects the different combinations, and combines the existing demangling implementations to produce the correct names and make all tests pass on libc++ + clang-cl.
Fixes #4542