Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't explicitly delete copy ctor of dynamic_format_arg_store #2664

Merged
merged 3 commits into from
Dec 23, 2021
Merged

Don't explicitly delete copy ctor of dynamic_format_arg_store #2664

merged 3 commits into from
Dec 23, 2021

Commits on Dec 18, 2021

  1. Don't explicitly delete copy ctor of dynamic_format_arg_store 

    Explicitly deleting the copy ctor causes the move constructor to not be
implicitly generated. This behaviour is different than what was in
v8.0.1 and causes code that relied on the move ctor of
dynamic_format_arg_store to break.
    @lucpelletier
    lucpelletier committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    73732e1 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2021

  1. Add test for dynamic_format_arg_store's move ctor

    @lucpelletier
    lucpelletier committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    18764e4 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2021

  1. include <memory>, don't use make_unique

    @lucpelletier
    lucpelletier committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    8e20ab5 View commit details
    Browse the repository at this point in the history