Deprecate _format UDL in code using FMT_DEPRECATED
#2646
Merged
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Mostly looks good but let's not introduce a new test for a deprecated function. Let's suppress the warning instead. |
That's a bit trickier since there are too many compilers. Of course, we could use some trivial checks and pragmas for GCC, Clang, and MSVC. But to get that warning suppressed in most compilers, something like this is needed - hedley/hedley.h. |
Then I would suggest removing the test altogether or limiting it to a single compiler where it's easy to suppress the deprecation warning. The test is pretty rudimentary anyway. |
alexezeder
force-pushed
the
deprecate_format_udl_in_code
branch
from
fe302bf
to
f2d1cbf
Compare
|
Thank you! |
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Feb 18, 2022
_format() was deprecated in fmtlib v8, see also fmtlib/fmt#2646 Signed-off-by: Kefu Chai <tchaikov@gmail.com>
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Feb 18, 2022
_format() was deprecated in fmtlib v8, see also fmtlib/fmt#2646 Signed-off-by: Kefu Chai <tchaikov@gmail.com>
nSedrickm
pushed a commit
to nSedrickm/ceph
that referenced
this pull request
Mar 21, 2022
_format() was deprecated in fmtlib v8, see also fmtlib/fmt#2646 Signed-off-by: Kefu Chai <tchaikov@gmail.com>
zalsader
pushed a commit
to zalsader/ceph
that referenced
this pull request
Apr 11, 2022
_format() was deprecated in fmtlib v8, see also fmtlib/fmt#2646 Signed-off-by: Kefu Chai <tchaikov@gmail.com>
dpaganel
pushed a commit
to dpaganel/ceph
that referenced
this pull request
May 17, 2022
_format() was deprecated in fmtlib v8, see also fmtlib/fmt#2646 Signed-off-by: Kefu Chai <tchaikov@gmail.com>
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Aug 15, 2022
_format() was deprecated in fmtlib v8, see also fmtlib/fmt#2646 Signed-off-by: Kefu Chai <tchaikov@gmail.com> (cherry picked from commit 3fd91d7)
idryomov
pushed a commit
to idryomov/ceph
that referenced
this pull request
Aug 15, 2022
_format() was deprecated in fmtlib v8, see also fmtlib/fmt#2646 Signed-off-by: Kefu Chai <tchaikov@gmail.com> (cherry picked from commit 3fd91d7)
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Aug 15, 2022
_format() was deprecated in fmtlib v8, see also fmtlib/fmt#2646 Signed-off-by: Kefu Chai <tchaikov@gmail.com> (cherry picked from commit 3fd91d7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originated from discussion in #2640.
The
_format-related test moved to separate test suite, since tests are not allowed to have warnings (withFMT_PEDANTICandFMT_WERROR) andFMT_DEPRECATEDproduces one. This way, we still can be sure that_formatworks fine.