Make MSVC use [[nodiscard]] #2615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uniformly detect attributes for __cplusplus and _MSVC_LANG
AlexGuteniev
commented
Nov 25, 2021
vitaut
reviewed
Nov 26, 2021
Comment on lines
+85
to
+89
| #ifdef _MSVC_LANG | ||
| # define FMT_CPLUSPLUS _MSVC_LANG | ||
| #else | ||
| # define FMT_CPLUSPLUS __cplusplus | ||
| #endif |
There was a problem hiding this comment.
What is going on here? Doesn't MSVC use the standard __cplusplus macro?
There was a problem hiding this comment.
/Zc:__cplusplus enables updated C++ macro. By default __cplusplus is defined to some ancient value.
As I read in MSVC STL chat, the reason for this default behavior is the compatibility with some open-source code, in which higher __cplusplus values enable not only legitimate C++ features, but also gcc extensions.
You already had _MSVC_LANG for [[fallthrough]], I'm just propagating it a bit further.
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uniformly detect attributes for __cplusplus and _MSVC_LANG