Reuse tm_writer in other formatters #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phprus
force-pushed
the
chrono-reuse-tm-1
branch
from
98ac2e2
to
81350e1
Compare
|
Rebased |
|
Thanks for another PR. It looks like the first commit only moves code around without changing functionality so could you move it to a separate PR to simplify reviewing this one? |
Merged
|
Yes. To use |
phprus
force-pushed
the
chrono-reuse-tm-1
branch
from
81350e1
to
1d756f7
Compare
|
@vitaut , PR updated. |
vitaut
requested changes
Nov 12, 2021
phprus
force-pushed
the
chrono-reuse-tm-1
branch
2 times, most recently
from
9a987ac
to
c7abf2c
Compare
|
Waiting for #2594 ... |
phprus
force-pushed
the
chrono-reuse-tm-1
branch
from
c7abf2c
to
e32ba3c
Compare
|
@vitaut, PR updated. |
vitaut
reviewed
Nov 12, 2021
phprus
force-pushed
the
chrono-reuse-tm-1
branch
from
e32ba3c
to
6ee9334
Compare
phprus
force-pushed
the
chrono-reuse-tm-1
branch
from
6ee9334
to
3c5c0d8
Compare
|
@vitaut, PR updated. |
vitaut
requested changes
Nov 14, 2021
phprus
force-pushed
the
chrono-reuse-tm-1
branch
from
3c5c0d8
to
13705c0
Compare
vitaut
approved these changes
Nov 14, 2021
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All locale-dependent formatting is now in the
tm_writerclass.