Declarations for shared library in Windows. #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -115,7 +115,7 @@ if (CPP11_FLAG AND FMT_PEDANTIC) | |||
| endif () | |||
|
|
|||
| set_target_properties(cppformat | |||
| PROPERTIES COMPILE_FLAGS "${FMT_EXTRA_COMPILE_FLAGS}") | |||
| PROPERTIES COMPILE_FLAGS "-DFMT_EXPORTS ${FMT_EXTRA_COMPILE_FLAGS}") | |||
There was a problem hiding this comment.
FMT_EXPORTS shouldn't be defined unconditionally, only when the BUILD_SHARED_LIBS CMake variable is set, because it breaks building the static library.
|
Thanks for the PR. I think this could be useful, but I have some comments/questions (above). |
Added __declspec(dllimport) and __declspec(dllexport) declarations when compiled in Windows.
|
Concerning your comments, I have made several improvements to the patch. I hope it will now allow to use cppformat as dynamic library in Windows. |
vitaut
added a commit
that referenced
this pull request
Dec 10, 2015
Declarations for shared library in Windows.
|
Merged with very minor adjustments in 1cba0ae. Thanks for contributing to the library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use cppformat in a shared library I have found that it does not compile in Windows (tested with MinGW32-w64). The reason for this is a lack fo __declspec(dllimport) and __declspec(dllexport) declaration. This PR solves this issue: when compiling shared library, one needs to add definition FMT_EXPORTS and skip it when using the library.
I hope this small improvement can help to make this great library even better.