Disable the -Wstringop-overflow warning from GCC 7 #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR but since it's a false positive please report to gcc maintainers. |
|
Gcc meta-bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88443 I think, this warnings are similar to existing bugs: |
vitaut
reviewed
Aug 2, 2021
| @@ -26,6 +26,10 @@ function(add_fmt_executable name) | |||
| if (MINGW) | |||
| target_link_libraries(${name} -static-libgcc -static-libstdc++) | |||
| endif () | |||
| if (CMAKE_CXX_COMPILER_ID MATCHES "GNU" AND | |||
There was a problem hiding this comment.
Could you add a link to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88443 or whatever the most relevant gcc bug is?
Also is it fixed in gcc 11?
There was a problem hiding this comment.
Done.
There are no warnings in gcc version 11.1.1 20210721 [revision 076930b9690ac3564638636f6b13bbb6bc608aea] (SUSE Linux).
phprus
force-pushed
the
gcc10-lto-warning
branch
from
42fc7a4
to
781bbf7
Compare
|
Thank you! |
sthagen
added a commit
to sthagen/fmtlib-fmt
that referenced
this pull request
Aug 3, 2021
Disable the -Wstringop-overflow warning from GCC 7 (fmtlib#2442)
PoetaKodu
pushed a commit
to pacc-repo/fmt
that referenced
this pull request
Nov 11, 2021
github-actions bot
pushed a commit
to THIS-IS-NOT-A-BACKUP/MKVToolNix
that referenced
this pull request
Nov 4, 2022
…due to too many false positives with libfmt. See fmtlib/fmt#2442 (comment) and https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88443
dr7ana
added a commit
to dr7ana/libquic
that referenced
this pull request
Jun 4, 2024
- FMT will trigger a gcc bug on stringop-overflow with gcc versions 11 and earlier - FMT issue fmtlib/fmt#2442 - FMT issue fmtlib/fmt#2708 - GCC bug tracker https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101854 - Confirming it still appears on gcc-11 https://godbolt.org/z/d15q4Exvz
dr7ana
added a commit
to dr7ana/libquic
that referenced
this pull request
Jun 4, 2024
- FMT will trigger a gcc bug on stringop-overflow with gcc versions 11 and earlier - FMT issue fmtlib/fmt#2442 - FMT issue fmtlib/fmt#2708 - GCC bug tracker https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101854 - Confirming it still appears on gcc-11 https://godbolt.org/z/d15q4Exvz
dr7ana
added a commit
to dr7ana/libquic
that referenced
this pull request
Jun 4, 2024
- FMT will trigger a gcc bug on stringop-overflow with gcc versions 11 and earlier - FMT issue fmtlib/fmt#2442 - FMT issue fmtlib/fmt#2708 - GCC bug tracker https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101854 - Confirming it still appears on gcc-11 https://godbolt.org/z/d15q4Exvz
dr7ana
added a commit
to dr7ana/libquic
that referenced
this pull request
Jun 4, 2024
- FMT will trigger a gcc bug on stringop-overflow with gcc versions 11 and earlier - FMT issue fmtlib/fmt#2442 - FMT issue fmtlib/fmt#2708 - GCC bug tracker https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101854 - Confirming it still appears on gcc-11 https://godbolt.org/z/d15q4Exvz
dr7ana
added a commit
to dr7ana/libquic
that referenced
this pull request
Jun 4, 2024
- FMT will trigger a gcc bug on stringop-overflow with gcc versions 11 and earlier - FMT issue fmtlib/fmt#2442 - FMT issue fmtlib/fmt#2708 - GCC bug tracker https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101854 - Confirming it still appears on gcc-11 https://godbolt.org/z/d15q4Exvz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for false positive warnings if LTO is enabled:
Discussion in Boost.JSON issue: boostorg/json#597