Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ambiguity in name lookup #2287

Merged
merged 1 commit into from
May 14, 2021

Conversation

DanielaE
Copy link
Contributor

@DanielaE DanielaE commented May 14, 2021

Unqualified calls to make_format_args may find the same name by ADL in <format> if this C++20 header happens to be directly or indirectly included in a translation unit. Do a qualified lookup instead.

Unqualified calls to 'make_format_args' may find the same name by ADL in <format> if this C++20 header happens to be directly or indirectly included in a translation unit. Do a qualified lookup instead.
@DanielaE
Copy link
Contributor Author

This addresses issue #2284

@DanielaE DanielaE marked this pull request as draft May 14, 2021 11:19
@DanielaE DanielaE marked this pull request as ready for review May 14, 2021 12:37
@vitaut vitaut merged commit ea94d6d into fmtlib:master May 14, 2021
@vitaut
Copy link
Contributor

vitaut commented May 14, 2021

Thank you!

@DanielaE DanielaE deleted the fix/prevent-ambiguity-in-name-lookup branch May 14, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants