Fix: fmt::ostream cannot be moved while holding buffered data #2197 #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
Mar 29, 2021
Comment on lines
+399
to
400
| other.clear(); | ||
| other.set(nullptr, 0); |
There was a problem hiding this comment.
I wonder if this can be replaced with
other = detail::buffer<char>();There was a problem hiding this comment.
It seems reasonable, but I prefer the consistency between set and clear.
Another issue is that creating an additional object in the ctor seems confusing.
|
Hmm.... @vitaut, is a line:
in the description of the first PR still necessary? |
Not really, removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2197