Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't include <cassert>. (#2148) #2152

Merged
merged 5 commits into from
Mar 4, 2021
Merged

Don't include <cassert>. (#2148) #2152

merged 5 commits into from
Mar 4, 2021

Commits on Feb 25, 2021

  1. Don't include <cassert>. (fmtlib#2148) 

    This commit replaces use of the assert() macro in format-inl.h with
FMT_ASSERT(). This allows us to drop the cassert include.
    @toojays
    toojays committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    2f699d2 View commit details
    Browse the repository at this point in the history

  2. FMT_GCC_VERSION is not defined when we include test-assert.h, use __G… 

    …CC__ instead.
    @toojays
    toojays committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    131e584 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. Don't explicitly suppress GCC's -Wterminate in tests' FMT_ASSERT. 

    Throwing from a separate function is enough to silence the warning, no need to
explicitly suppress it.
    @toojays
    toojays committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    4471b2f View commit details
    Browse the repository at this point in the history

  2. Remove messages from assertions added in 2f699d2.

    @toojays
    toojays committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    2f7a6d8 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. Correct formatting around throw_assertion_failure().

    @toojays
    toojays committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    0b8276f View commit details
    Browse the repository at this point in the history