Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detail::write in one more place relevant to printf with long argument… #2016

Merged
merged 4 commits into from
Nov 13, 2020
Merged

detail::write in one more place relevant to printf with long argument… #2016

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f5155b
detail::write in one more place relevant to printf with long argument…
rimathia Nov 12, 2020
960f5bd
remove whitespace change
rimathia Nov 12, 2020
6684314
add specialization of copy_str instead of using detail::write in it
rimathia Nov 13, 2020
7ed5c69
remove now unnecessary overload
rimathia Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions include/fmt/format.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,6 +605,14 @@ OutputIt copy_str(InputIt begin, InputIt end, OutputIt it) {
return it;
}

template <typename OutChar, typename InputIt,
FMT_ENABLE_IF(!needs_conversion<InputIt, OutChar>::value)>
buffer_appender<OutChar> copy_str(InputIt begin, InputIt end,
buffer_appender<OutChar> out) {
get_container(out).append(begin, end);
return out;
}

template <typename Char, typename InputIt>
inline counting_iterator copy_str(InputIt begin, InputIt end,
counting_iterator it) {
Expand Down Expand Up @@ -2055,13 +2063,6 @@ OutputIt write(OutputIt out, basic_string_view<Char> value) {
return base_iterator(out, it);
}

template <typename Char>
buffer_appender<Char> write(buffer_appender<Char> out,
basic_string_view<Char> value) {
get_container(out).append(value.begin(), value.end());
return out;
}

template <typename Char, typename OutputIt, typename T,
FMT_ENABLE_IF(is_integral<T>::value &&
!std::is_same<T, bool>::value &&
Expand Down