Fix warning C4018: '<=': signed/unsigned mismatch #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
Oct 1, 2020
include/fmt/format-inl.h
Outdated
| @@ -1790,8 +1790,8 @@ bool check_divisibility_and_divide_by_pow5(uint32_t& n) FMT_NOEXCEPT { | |||
| template <int N> uint32_t small_division_by_pow10(uint32_t n) FMT_NOEXCEPT { | |||
| static constexpr struct { | |||
| uint32_t magic_number; | |||
| int shift_amount; | |||
| int divisor_times_10; | |||
| uint32_t shift_amount; | |||
There was a problem hiding this comment.
Is this necessary? The warning only refers to divisor_times_10.
There was a problem hiding this comment.
Can shift_amount be less then 0?
There was a problem hiding this comment.
No but if this doesn't cause a warning, please keep it as is.
There was a problem hiding this comment.
Are there any guarantees that it won't give out in the future?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.