Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid possible namespace clash for fmt #1522

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Avoid possible namespace clash for fmt #1522

merged 1 commit into from
Jan 15, 2020

Commits on Jan 15, 2020

  1. Avoid namespace clash for fmt 

    ## Problem

In the case of an existing `fmt` namespace (in my project this looks like `Project::fmt`) it is possible to get a namespace clash in debug builds (MSVC 2017)

## Proposed Solution

When referencing `fmt` internally, be explicit that it is relative to the global namespace using `::fmt`
    @lefticus
    lefticus authored Jan 15, 2020
    Configuration menu
    Copy the full SHA
    a9d1fac View commit details
    Browse the repository at this point in the history