-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import test for CUDA project #1285
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ba82f54
test cuda: import fmt in CUDA source code
luncliff be27926
test cuda: add more comment / macro check
luncliff bfa245e
Merge branch 'master' into cuda
luncliff 14c5dab
test cuda: <fmt/core.h> checks NVCC and CUDA
luncliff 30c5209
test cuda: applied PR reviews
luncliff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,105 @@ | ||
|
||
# | ||
# We can find some usecases which follows the guide of CMake. | ||
# The way replaces 'find_package(CUDA)' to 'enable_language(CUDA)'. | ||
# And let the CMake built-in functions to use NVCC. | ||
# | ||
# See: https://cmake.org/cmake/help/latest/module/FindCUDA.html#replacement | ||
# | ||
# However, such CMake versions are pretty high (3.10 or later). | ||
# And we can't sure most of the CUDA projects are using those latest | ||
# because the latest C++ standard for NVCC is C++ 14 at this moment. | ||
# | ||
# In conclusion, | ||
# this test should follow the version of the Root CMakeLists.txt | ||
# and rely on 'find_package(CUDA)'. | ||
# | ||
|
||
# | ||
# This part is for future update | ||
# | ||
# cmake_minimum_required(VERSION 3.10) | ||
# project(fmt-cuda-test LANGUAGES CXX CUDA) # see 'enable_language(CUDA)' | ||
# | ||
|
||
# Follow the Root CMakeLists.txt | ||
cmake_minimum_required(VERSION 3.1) | ||
|
||
# We already knows the packages. This part shows example. | ||
# find_package(CUDA 9.0 REQUIRED) | ||
# find_package(FMT 6.0 REQUIRED) | ||
|
||
# | ||
# Update these when NVCC becomes ready for C++ 17 features | ||
# https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#cpp14-language-features | ||
# | ||
set(CMAKE_CUDA_STANDARD 14) | ||
set(CMAKE_CUDA_STANDARD_REQUIRED 14) | ||
|
||
# | ||
# https://docs.nvidia.com/cuda/cuda-compiler-driver-nvcc/index.html | ||
# | ||
list(APPEND CUDA_NVCC_FLAGS "-std=c++14") | ||
if(MSVC) | ||
# this is the solution of pytorch | ||
# https://github.com/pytorch/pytorch/pull/7118 | ||
list(APPEND CUDA_NVCC_FLAGS "-Xcompiler" "/std:c++14") | ||
list(APPEND CUDA_NVCC_FLAGS "-Xcompiler" "/Zc:__cplusplus") | ||
# for the reason of this -Xcompiler options, see below ... | ||
endif() | ||
|
||
# | ||
# In this test, we will assume that | ||
# the user is going to compile CUDA source codes with some libraries. | ||
# Of course, it's 'fmt' in this case. | ||
# | ||
# In addition to that, | ||
# this test will invoke both C++ Host compiler and NVCC by providing | ||
# another (non-CUDA) C++ source code | ||
# | ||
cuda_add_executable(fmt-in-cuda-test | ||
cuda-cpp14.cu | ||
cpp14.cc | ||
) | ||
|
||
target_compile_features(fmt-in-cuda-test | ||
PRIVATE | ||
cxx_std_14 # just make sure of the property | ||
) | ||
|
||
get_target_property(IN_USE_CUDA_STANDARD | ||
fmt-in-cuda-test CUDA_STANDARD | ||
) | ||
message(STATUS "cuda_standard: ${IN_USE_CUDA_STANDARD}") | ||
|
||
get_target_property(IN_USE_CUDA_STANDARD_REQUIRED | ||
fmt-in-cuda-test CUDA_STANDARD_REQUIRED | ||
) | ||
message(STATUS "cuda_standard_required: ${IN_USE_CUDA_STANDARD_REQUIRED}") | ||
|
||
# | ||
# https://cmake.org/cmake/help/latest/module/FindCUDA.html | ||
# | ||
# From the document, you can see "The default is to use no keyword" | ||
# | ||
target_link_libraries(fmt-in-cuda-test | ||
# PUBLIC | ||
fmt::fmt | ||
) | ||
|
||
if(MSVC) | ||
# | ||
# This part is for (non-CUDA) C++ code. | ||
# MSVC can define incorrect '__cplusplus' macro. | ||
# Fix for the issue is to use additional compiler flag. | ||
# | ||
# See Also: | ||
# https://devblogs.microsoft.com/cppblog/msvc-now-correctly-reports-__cplusplus/ | ||
# https://github.com/Microsoft/vscode-cpptools/issues/2595 | ||
# | ||
target_compile_options(fmt-in-cuda-test | ||
PRIVATE | ||
/Zc:__cplusplus | ||
/permissive- | ||
) | ||
endif() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
|
||
#include <fmt/core.h> | ||
|
||
// | ||
// The purpose of this part is to ensure NVCC's host compiler also supports | ||
// the standard version. See 'cuda-cpp14.cu'. | ||
// | ||
// https://en.cppreference.com/w/cpp/preprocessor/replace#Predefined_macros | ||
// | ||
static_assert(__cplusplus >= 201402L, "expect C++ 2014 for host compiler"); | ||
|
||
auto make_message_cpp() -> std::string { | ||
return fmt::format("host compiler \t: __cplusplus == {}", __cplusplus); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
|
||
// | ||
// Direct NVCC command line example: | ||
// | ||
// nvcc.exe ./cuda-cpp14.cu -x cu -I"../include" -l"fmtd" -L"../build/Debug" \ | ||
// -std=c++14 -Xcompiler /std:c++14 -Xcompiler /Zc:__cplusplus | ||
// | ||
|
||
// | ||
// Ensure that we are using the latest C++ standard for NVCC | ||
// The version is C++14 | ||
// | ||
// https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#c-cplusplus-language-support | ||
// https://en.cppreference.com/w/cpp/preprocessor/replace#Predefined_macros | ||
// | ||
static_assert(__cplusplus >= 201402L, "expect C++ 2014 for nvcc"); | ||
|
||
// | ||
// https://docs.nvidia.com/cuda/cuda-compiler-driver-nvcc/index.html#nvcc-identification-macro | ||
// | ||
// __NVCC__ is for NVCC compiler | ||
// __CUDACC__ is for CUDA(.cu) source code | ||
// | ||
// Since we don't know the actual case in this header, checking both macro | ||
// will prevent possible pitfalls ... | ||
// | ||
// --- this check is moved into the <fmt/core.h> --- | ||
// | ||
// #if defined(__NVCC__) || defined(__CUDACC__) | ||
// # define FMT_DEPRECATED // suppress [[deprecated]] attribute | ||
// #endif | ||
#include <fmt/core.h> | ||
|
||
#include <cuda.h> | ||
#include <iostream> | ||
|
||
extern auto make_message_cpp() -> std::string; | ||
extern auto make_message_cuda() -> std::string; | ||
|
||
int main(int, char*[]) { | ||
std::cout << make_message_cuda() << std::endl; | ||
std::cout << make_message_cpp() << std::endl; | ||
} | ||
|
||
auto make_message_cuda() -> std::string { | ||
return fmt::format("nvcc compiler \t: __cplusplus == {}", __cplusplus); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here