cmake: default FMT_PKGCONFIG_DIR to a relative path #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jasonszang, thanks for the PR! Since this is your first contribution to {fmt}, please review CONTRIBUTING.md, particularly the part about licensing, and comment here whether you agree with it being applied to your contributions including this PR. |
|
Hi @vitaut ! I've reviewed CONTRIBUTING.md and I agree with the licensing. Thank you! |
|
Merged, thanks! |
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cmake improvement that defaults FMT_PKGCONFIG_DIR properly to a relative path. Currently FMT_PKGCONFIG_DIR will be defaulted to an absolute path based on the initial value of CMAKE_INSTALL_PREFIX, and does not automatically change with it.