Implement 'chrono' formatting specifiers '%Q' and '%q' (#1004) #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
Jan 27, 2019
| @@ -18,6 +18,33 @@ | |||
|
|
|||
| FMT_BEGIN_NAMESPACE | |||
|
|
|||
| template <typename Period> FMT_CONSTEXPR const char* get_units() { | |||
There was a problem hiding this comment.
This and specializations should probably be internal.
include/fmt/chrono.h
Outdated
| @@ -118,6 +145,12 @@ FMT_CONSTEXPR const Char* parse_chrono_format(const Char* begin, | |||
| case 'p': | |||
| handler.on_am_pm(); | |||
| break; | |||
| case 'Q': | |||
| handler.on_value(); | |||
There was a problem hiding this comment.
on_value is a bit too generic. What kind of value is allowed here, time?
There was a problem hiding this comment.
Renamed to clarify the intent.
Howard Hinnant's 'date' library recently gained these two new formatting specifiers. This implementation in {fmt} includes support for 'std::chrono::duration' specializations with floating-point representation types and user-definable precision.
Signed-off-by: Daniela Engert <dani@ngrt.de>
DanielaE
force-pushed
the
feature/chrono-specs-%Q+%q
branch
from
6c7f4b4
to
daa7f75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howard Hinnant's 'date' library recently gained these two new formatting specifiers. This implementation in {fmt} includes support for 'std::chrono::duration' specializations with floating-point representation types and user-definable precision.
Signed-off-by: Daniela Engert dani@ngrt.de