Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UtilTest.StringRefCompare: fails if std::char_traits<T>::compare returns a value outside [-1;1] #225

Closed
jackyf opened this issue Nov 9, 2015 · 1 comment
Closed

UtilTest.StringRefCompare: fails if std::char_traits<T>::compare returns a value outside [-1;1] #225

jackyf opened this issue Nov 9, 2015 · 1 comment

Comments

@jackyf
Copy link

jackyf commented Nov 9, 2015

Hi,

Thank you for the portability patch merges. Still one new issue on a newest master:

Extract from running tests on Debian s390x and arm64 autobuilders:
-------------------8<--------------------
[ RUN ] UtilTest.StringRefCompare
/«BUILDDIR»/cppformat-2.0.0alpha20151107+ds3/test/util-test.cc:726: Failure
Value of: StringRef("fop").compare(StringRef("foo"))
Actual: 8
Expected: 1
/«BUILDDIR»/cppformat-2.0.0alpha20151107+ds3/test/util-test.cc:727: Failure
Value of: StringRef("foo").compare(StringRef("fop"))
Actual: -8
Expected: -1
[ FAILED ] UtilTest.StringRefCompare (0 ms)
------------------->8---------------------
vitaut added a commit that referenced this issue Nov 10, 2015
@vitaut
Don't assume that char_traits::compare returns +/-1 (#225)
aa741ba
@vitaut
Copy link
Contributor

vitaut commented Nov 10, 2015

Fixed in aa741ba. Thanks!

@vitaut vitaut closed this as completed Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jackyf @vitaut