Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we make FMT_DEBUG_POSTFIX as a cache variable #1566

Closed
deryck1031 opened this issue Feb 27, 2020 · 2 comments
Closed

Can we make FMT_DEBUG_POSTFIX as a cache variable #1566

deryck1031 opened this issue Feb 27, 2020 · 2 comments

Comments

@deryck1031
Copy link

Currently there is no way to disable adding 'd' in debug build with lib name like libfmtd.a. Can you
please make it configurable? 'd' is added by below code:

set(FMT_DEBUG_POSTFIX d)
@vitaut
Copy link
Contributor

vitaut commented Feb 27, 2020

Sure. Could you submit a PR?

vitaut added a commit that referenced this issue Mar 4, 2020
@vitaut
Make FMT_DEBUG_POSTFIX a cache variable (#1566)
1c200c9
vitaut added a commit that referenced this issue Mar 4, 2020
@vitaut
Make FMT_DEBUG_POSTFIX a cache variable (#1566)
0c6919e
@vitaut
Copy link
Contributor

vitaut commented Mar 4, 2020

Done in 0c6919e.

@vitaut vitaut closed this as completed Mar 4, 2020
teajay-fr pushed a commit to teajay-fr/fmt that referenced this issue Mar 18, 2020
@vitaut
Make FMT_DEBUG_POSTFIX a cache variable (fmtlib#1566)
4bd4161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @deryck1031