FormatTest.StrError fails on Solaris

[vedranmiletic]

OpenIndiana Hipster 2019.04 just like in #1203, GCC 8.3.0, fmt revision 2711cb1 compiling nicely now (thanks!). However, when running tests I get:

[----------] 5 tests from FormatTest
[ RUN      ] FormatTest.ArgConverter
[       OK ] FormatTest.ArgConverter (0 ms)
[ RUN      ] FormatTest.FormatNegativeNaN
[       OK ] FormatTest.FormatNegativeNaN (0 ms)
[ RUN      ] FormatTest.StrError
test/format-impl-test.cc:202: Failure
Value of: message
  Actual: "Argument out of domain"
Expected: ""
[  FAILED  ] FormatTest.StrError (1 ms)
[ RUN      ] FormatTest.FormatErrorCode
[       OK ] FormatTest.FormatErrorCode (0 ms)
[ RUN      ] FormatTest.CountCodePoints
[       OK ] FormatTest.CountCodePoints (0 ms)
[----------] 5 tests from FormatTest (1 ms total)

[----------] Global test environment tear-down
[==========] 17 tests from 3 test cases ran. (3 ms total)
[  PASSED  ] 16 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] FormatTest.StrError

[vitaut]

Looks like strerror* on OpenIndiana Hipster has the same issue as MinGW. The workaround is to change

#ifndef __MINGW32__

to

#if !defined(__MINGW32__) && !defined(...) // <- put some macro to detect your system here

in

fmt/test/format-impl-test.cc

Line 195 in 2711cb1

#ifndef __MINGW32__

Could you submit a PR since you are in the best position to check that it works?