error: 'strtod_l' was not declared in this scope on Solaris

[vedranmiletic]

Trying to compile fmt on OpenIndiana Hipster 2019.04:

[1/165] Compiling C++ object 'subprojects/fmt-5.3.0/8e83f07@@fmt@sha/src_posix.cc.o'.
FAILED: subprojects/fmt-5.3.0/8e83f07@@fmt@sha/src_posix.cc.o 
c++ -Isubprojects/fmt-5.3.0/8e83f07@@fmt@sha -Isubprojects/fmt-5.3.0 -I../subprojects/fmt-5.3.0 -I../subprojects/fmt-5.3.0/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++11 -g -fPIC -MD -MQ 'subprojects/fmt-5.3.0/8e83f07@@fmt@sha/src_posix.cc.o' -MF 'subprojects/fmt-5.3.0/8e83f07@@fmt@sha/src_posix.cc.o.d' -o 'subprojects/fmt-5.3.0/8e83f07@@fmt@sha/src_posix.cc.o' -c ../subprojects/fmt-5.3.0/src/posix.cc
In file included from ../subprojects/fmt-5.3.0/src/posix.cc:13:
../subprojects/fmt-5.3.0/include/fmt/posix.h: In member function 'double fmt::v5::Locale::strtod(const char*&) const':
../subprojects/fmt-5.3.0/include/fmt/posix.h:316:21: error: 'strtod_l' was not declared in this scope
     double result = strtod_l(str, &end, locale_);
                     ^~~~~~~~
../subprojects/fmt-5.3.0/include/fmt/posix.h:316:21: note: suggested alternative: 'strtod'
     double result = strtod_l(str, &end, locale_);
                     ^~~~~~~~
                     strtod
[3/165] Compiling C++ object 'subprojects/spdlog-1.3.1/tests/7c1051b@@tests_exe@exe/test_errors.cpp.o'.

[vedranmiletic]

Forgot to mention I'm using GCC 8.3:

$ g++ --version
g++ (OpenIndiana 8.3.0-OI-0) 8.3.0

OpenIndiana provides many versions of GCC and Clang 4.0, but I'm using the current release that doesn't include a fix for #1115.

[vitaut]

Should be fixed in d5d5865. Could you confirm that it works for you?

[vedranmiletic]

I will check this week, I managed to somehow break my installation of OpenIndiana right after reporting this.

[vedranmiletic]

Confirmed working.