Don't assume that StringRef::compare returns +/-1

fmtlib · Nov 11, 2015 · d6d019a · d6d019a
1 parent 4779628
commit d6d019a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/test/util-test.cc b/test/util-test.cc
@@ -726,8 +726,8 @@ TEST(UtilTest, StringRefCompare) {
   EXPECT_EQ(0, StringRef("foo").compare(StringRef("foo")));
   EXPECT_GT(StringRef("fop").compare(StringRef("foo")), 0);
   EXPECT_LT(StringRef("foo").compare(StringRef("fop")), 0);
-  EXPECT_EQ(1, StringRef("foo").compare(StringRef("fo")));
-  EXPECT_EQ(-1, StringRef("fo").compare(StringRef("foo")));
+  EXPECT_GT(StringRef("foo").compare(StringRef("fo")), 0);
+  EXPECT_LT(StringRef("fo").compare(StringRef("foo")), 0);
   CheckOp<std::equal_to>();
   CheckOp<std::not_equal_to>();
   CheckOp<std::less>();