Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving stock class #80

Merged
merged 4 commits into from
Jul 7, 2023

Conversation

PietropaoloFrisoni
Copy link
Collaborator

The docstrings are updated to reflect the changes.

@fmilthaler
Copy link
Owner

Thanks for that as well. Fully agree that Stock should be removed from portfolio.py. As part of that, please also move the test test_Stock() in its own test file tests/test_stock.py.

@PietropaoloFrisoni
Copy link
Collaborator Author

I moved the test into a separate file as well. I maintained some of the global variables (even if not all of them are used in test_Stock) in case in the future one wants to add a few more stock tests.

Since I still do not have my quandl API key, I performed the test using yfinance but I changed back to quandl before the commit. Obviously, it should work with quandl as well.

@fmilthaler fmilthaler merged commit 650910e into fmilthaler:master Jul 7, 2023
@PietropaoloFrisoni PietropaoloFrisoni deleted the moving_stock_class branch July 7, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants