Bugfix/deprecation num py #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "append" method in Pandas is deprecated since version 1.4.0. It can still be called with the underscore prefix, which allows to easily update the code (and it goes very well with black formatter). In future versions, it might be necessary to replace "DataFrame.append" with "Pandas.concat".
…t64 if the allocation only contains integers. An instance of numpy.int64 is not recognized as instance of int, as they are two different classes. This causes the error message since the total investment is not recognized as integer. Courious: trying with allocations equal to 20^(200), the returned number is an instance of "int" instead of "numpy.int64".
…ences is deprecated. It is now necessary to specify the additional parameter 'dtype=object'.
|
Thanks again. That looks good to me. Once the other PRs are merged (and this one updated), I'll approve and merge this one! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72. Creating a numpy ndarray from ragged nested sequences is deprecated.
It is now necessary to specify the additional parameter 'dtype=object'.