Chore/consistent type hints #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orking in the toml file for some reason)
…accept series and dfs as input, always returns a series though! Change needed for Asset
…commit fixes that.
…s are used correctly
fmilthaler
force-pushed
the
chore/consistent-type-hints
branch
2 times, most recently
from
3f20d69 to
968afc2
Compare
fmilthaler
force-pushed
the
chore/consistent-type-hints
branch
from
968afc2 to
1c61a22
Compare
|
@PietropaoloFrisoni This is finally ready to be merged. Important NotePlease, do not review this thoroughly. I only assigned this PR to you, so that you can have a quick look at some of the changes I point out to you. Please ignore everything else, it is just too much to review. :) I also left you a message on slack. |
fmilthaler
commented
Aug 15, 2023
fmilthaler
commented
Aug 15, 2023
fmilthaler
commented
Aug 15, 2023
fmilthaler
commented
Aug 15, 2023
fmilthaler
commented
Aug 15, 2023
fmilthaler
commented
Aug 15, 2023
|
Congrats man! This is quite a careful and thorough work. it certainly brings |
PietropaoloFrisoni
approved these changes
Aug 15, 2023
PietropaoloFrisoni
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using type hints throughout FinQuant and introducing type checks in functions/methods that raise appropriate error messages if an argument is of an unexpected type.
This commit also introduces custom data types, e.g.
FLOATasUnion[np.floating, float]and more to simplify type hints. Moreover, type validation is now done with a new module/functiontype_validationthat also simplifies type validations.Finally, the documentation for all modules in
finquanthas been updated.This closes #94 and also closes #118.