Refactor/asset stock market index #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Asset: parent class of stock - Stock: child of Asset, specific class for a stock within a portfolio - Market: child of Asset, specific class for a market index This commit renames market.py to asset.py and makes modifications in stock.py. What is missing is the new class/module for Market and modification in asset.py
|
@PietropaoloFrisoni Let me know what you think about the new structure. Any feedback is welcome. This is not urgent, so look at it whenever you have time. |
PietropaoloFrisoni
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the code:
Instead of having almost identical classes for Stock and Market, we now introduce a parent class Asset for both.