Use rule(parent = ...) when possible
#145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
rule-extension
branch
5 times, most recently
from
bc18881 to
131e354
Compare
fmeum
changed the title
rule(parent = ...) when possible
fmeum
force-pushed
the
rule-extension
branch
3 times, most recently
from
90fa3be to
44c40e4
Compare
fmeum
force-pushed
the
rule-extension
branch
from
44c40e4 to
f96dceb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying
with_cfgto a rule with Bazel 8, it can be extended with a transition rather than being wrapped, which avoids a lot of dirty tricks needed to forward common attributes and providers.This doesn't work with automatic reset yet as it would require returning two rules and a macro. In the future, this could be resolved by merging the transitioning alias into the extended rule and returning the macro first.