Add option to force SRGB off within opengl #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmenozzi
reviewed
Oct 23, 2023
| @@ -118,6 +121,8 @@ impl ArgValues { | |||
| (None, false) | |||
| }; | |||
|
|
|||
| let force_srgb_off = matches.is_present("force_srgb_off"); | |||
There was a problem hiding this comment.
Here and elsewhere (README.md, src/cli.yml), I'd prefer force-srgb-off (i.e. dashes instead of underscores
There was a problem hiding this comment.
It seems there is another parameter that is making use of underscores anisotropic_max. Should this one be changed to dashes too while I'm at it :D
There was a problem hiding this comment.
Doh! I missed that. In that case, for the sake of both uniformity and backwards compatibility, let's just use underscores for everything :P
Adjusted help message
fmenozzi
approved these changes
Oct 24, 2023
| @@ -118,6 +121,8 @@ impl ArgValues { | |||
| (None, false) | |||
| }; | |||
|
|
|||
| let force_srgb_off = matches.is_present("force_srgb_off"); | |||
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following issue #29
By default, GFX enables FRAMEBUFFER_SRGB in OpenGL. Even if shadertoy only uses RGBA at some point the conversion to SRGB is made which leads to disparities between shadertoy.com's rendering and shadertoy-rs's. This PR adds the option to disable FRAMEBUFFER_SRGB in OpenGL with a flag.
Unsafe has to be used in this case.
Shader used to compare changes.
Before:
After:
For more details see initial issue as well as :