Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing figure caption #223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing figure caption #223

wants to merge 1 commit into from

Conversation

MevenBertrand
Copy link
Contributor

Currently the figure captions are of the form "Figure 3.1.:", which seems weird to me: why the point followed by a column? This PR removes that in the sidefigure and figure* environments, it might need adjustments for other kinds of floats as well. Please add a commit to this PR if this is the case!

@fmarotta
Copy link
Owner

Thanks! Having a dot after numbers is a German convention which I always disable by passing the numbers=noenddot option to kaobook, and I personally like the semicolon, but on the other hand I also see how it clashes with the dot (at the very least, this shouldn't be the default behaviour... my bad, sorry about that). Maybe a good compromise could be to choose the labelsep with an option, so that you could choose either "enddot + space" or "noenddot + semicolon". What do you think? :)

@MevenBertrand
Copy link
Contributor Author

MevenBertrand commented Mar 28, 2022 •
edited
Loading

I agree, I like the semi-colon too! Your solution seems better than mine, I think in this case it might be a lack of documentation about the option noenddot option (at least I missed that solution). Probably adding a note somewhere on that, and maybe putting that option in the examples document might be enough? Otherwise indeed implementing my change as an option so that people who want to keep the German convention can is also a way to go.

MevenBertrand added a commit to MevenBertrand/kaobook that referenced this pull request Mar 28, 2022
@MevenBertrand
Revert "fixing figures caption"
01805d4 
This reverts commit edb76f8.
The right fix is given in fmarotta#223
MevenBertrand added a commit to MevenBertrand/kaobook that referenced this pull request Apr 2, 2022
@MevenBertrand
Revert "fixing figures caption"
fcba867 
This reverts commit edb76f8.
The right fix is given in fmarotta#223
@fredguth
Copy link

I guess this PR won't be merged. :-)

alxvth added a commit to alxvth/kaobook that referenced this pull request May 4, 2024
@alxvth
Added
db8c550 
fmarotta#257 (Add the wide algorithm* environment and make its caption style consistent with kaobook)
fmarotta#225 (Fix issues related to listings)
fmarotta#223 (Fixing figure caption)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MevenBertrand @fmarotta @fredguth