"test/yaml-test-suite" submodule broken by upstream #77
Comments
stefantalpalaru
added a commit
to status-im/nimbus-eth2
that referenced
this issue
Feb 11, 2020
because of flyx/NimYAML#77
mratsim
added a commit
to status-im/nim-blscurve
that referenced
this issue
Feb 13, 2020
mratsim
added a commit
to status-im/nim-blscurve
that referenced
this issue
Feb 13, 2020
|
submodule was always a pain, should probably switch to git-subrepo so that upstream can't break it… |
|
As long as you target a certain commit and upstream decides to make that commit disappear, there's nothing you can do to prevent it. |
|
git-subrepo will put an actual clone of upstream into this repository. If a commit vanishes upstream, it may be tricky to update the clone but that would only affect maintainers. Users will still be able to clone this repo with the currently cloned upstream state and thus not be affected by upstream, which is the goal. |
|
Is there a workaround for this atm? |
mratsim
added a commit
to status-im/nim-blscurve
that referenced
this issue
Mar 1, 2020
…ture scheme to draft standard (#36) * Rework the readme * Prepare transitioning to the new IETF API * Delete obsolete README, add Cipher suite ID (BLS_SIG_BLS12381G2-SHA256-SSWU-RO-_NUL_) * Stash BLS keygen implementation * Implement CoreSign, CoreVerify and signature aggregation * Implement CoreAggregateVerify * Implement message signing/verification, proof-of-possession generation/verification, aggregate verification/fast aggregate verification * add aggregate verify. Enforce proper usage of proofs at the API level for signature validation * Implement key pair generator * Move old test vectors, add Eth2 v0.10.0 test vectors * Fix paths for the moved old test suite * Add the spec overload that don't enforce proof-of-possessions usage. Needed for test vectors * Prevent non constant-time comparison of secret-key (and comparison altogether) * Add IO + fix types/API issues * IO: include to allow accessing private fields * Add (failing) signing test vectors * Add hex dumps - the hex dumps are the same! (but comparison fails for unknown reason) * Fix sign test by exporting an `==` proc * Factor out common part of the tests * Properly handle tampered signature in the test vector * Add signature aggregation tests * Add fast aggregate verify test (failing to wrong test - ethereum/consensus-specs#1618) * Switch coreAggregateVerify to a streaming API to accomodate AoS SoA and interleaving proofs of possessions * Add AggregateVerify test for both SoA and AoS API * Comment out internal tests, skip buggy upstream test, add to nimble * don't export init/update * Add yaml testing dependency to CI * Use NimYAML fork (flyx/NimYAML#77) * YAML fix was not fully applied * NimYAML update lost in the rebase/force push * Hopefully fix NimYAML build issues * same NimYAML fix on POSIX
Closed
2 tasks
|
I changed the commit reference to a release tag, they surely won't break those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Upstream issue: yaml/yaml-test-suite#51
The text was updated successfully, but these errors were encountered: