Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Adding support opentelemtry to enable performance observability #149

Closed
wants to merge 6 commits into from

Conversation

hamersaw
Copy link
Contributor

@hamersaw hamersaw commented Jan 3, 2023

TL;DR

This PR adds wrappers over the opentelementry framework to support exporting distributed traces from Flyte components. The goal is to instrument Flyte microservices to improve performance observability.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

NA

Follow-up issue

NA

Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Dan Rammer <daniel@union.ai>
Signed-off-by: Dan Rammer <daniel@union.ai>
Signed-off-by: Dan Rammer <daniel@union.ai>
Signed-off-by: Dan Rammer <daniel@union.ai>
Signed-off-by: Dan Rammer <daniel@union.ai>
@hamersaw hamersaw mentioned this pull request Jan 3, 2023
8 tasks
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #149 (1810069) into master (80d1624) will increase coverage by 0.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   67.94%   68.23%   +0.28%     
==========================================
  Files          69       69              
  Lines        4077     4089      +12     
==========================================
+ Hits         2770     2790      +20     
+ Misses       1148     1141       -7     
+ Partials      159      158       -1     
Flag Coverage Δ
unittests 68.23% <100.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
storage/cached_rawstore.go 77.10% <100.00%> (+1.78%) ⬆️
storage/protobuf_store.go 74.19% <100.00%> (+2.76%) ⬆️
cache/auto_refresh.go 77.85% <0.00%> (+5.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hamersaw
Copy link
Contributor Author

hamersaw commented Feb 1, 2023

closed in favor of #146

@hamersaw hamersaw closed this Feb 1, 2023
@hamersaw hamersaw deleted the feature/performance-observability branch February 1, 2023 16:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant