Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Migrate to go module and remove old Hive integration tests #36

Merged
merged 8 commits into from
Jan 27, 2020
+1,387 −1,448
Merged

Migrate to go module and remove old Hive integration tests #36

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8ace1e6
migrate to go module
honnix Nov 28, 2019
dfc6890
try to fix lint
honnix Nov 28, 2019
d83cb70
incorporate latest boilerplate changes
honnix Jan 21, 2020
e766780
use latest boilerplate
honnix Jan 24, 2020
1ff094d
updated
Jan 24, 2020
776af84
update boilerplate
Jan 27, 2020
983cb6f
updating
Jan 27, 2020
9d6080e
change comment
Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,14 @@ require (
sigs.k8s.io/controller-runtime v0.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to depend on a SHA, is this version inclusive?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.4.0 includes sha 40070e2a1958c3d974ba95da883a2bd088137789

)

// Pin the version of client-go to something that's compatible with katrogan's fork of api and apimachinery
// Type the following
// replace k8s.io/client-go => k8s.io/client-go kubernetes-1.16.2
// and it will be replaced with the 'sha' variant of the version

replace (
github.com/GoogleCloudPlatform/spark-on-k8s-operator => github.com/lyft/spark-on-k8s-operator v0.1.3
k8s.io/api => github.com/lyft/api v0.0.0-20191031200350-b49a72c274e0
k8s.io/apimachinery => github.com/lyft/apimachinery v0.0.0-20191031200210-047e3ea32d7f
k8s.io/client-go => k8s.io/client-go v0.0.0-20191016111102-bec269661e48
)

// k8s.io/client-go kubernetes-1.17.2
Loading