Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add labels and annotations to with_overrides #3037

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add labels and annotations to with_overrides #3037

wants to merge 3 commits into from

Conversation

pryce-turner
Copy link
Contributor

@pryce-turner pryce-turner commented Jan 6, 2025 •
edited
Loading

Why are the changes needed?

Improvement to allow setting labels and annotations dynamically at run time for things like cost allocation

What changes were proposed in this pull request?

Adds labels and annotations to with_overrides()

How was this patch tested?

TBD

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

flyteorg/flyte#6145

Docs link

TBD

@pryce-turner
WIP
8890130 
Signed-off-by: pryce-turner <pryce.turner@gmail.com>
@flyte-bot
Copy link
Contributor

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at eduardo@union.ai.

@pryce-turner pryce-turner mentioned this pull request Jan 6, 2025
Draft
3 tasks
@pryce-turner
Added correct models for labels and anno
f4f674b 
Signed-off-by: pryce-turner <pryce.turner@gmail.com>
@pryce-turner
Added tests and fixed NodeMetadata
a2db6fd 
Signed-off-by: pryce-turner <pryce.turner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wild-endeavor wild-endeavor Awaiting requested review from wild-endeavor wild-endeavor will be requested when the pull request is marked ready for review wild-endeavor is a code owner

@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 will be requested when the pull request is marked ready for review kumare3 is a code owner

@eapolinario eapolinario Awaiting requested review from eapolinario eapolinario will be requested when the pull request is marked ready for review eapolinario is a code owner

@pingsutw pingsutw Awaiting requested review from pingsutw pingsutw will be requested when the pull request is marked ready for review pingsutw is a code owner

@cosmicBboy cosmicBboy Awaiting requested review from cosmicBboy cosmicBboy will be requested when the pull request is marked ready for review cosmicBboy is a code owner

@samhita-alla samhita-alla Awaiting requested review from samhita-alla samhita-alla will be requested when the pull request is marked ready for review samhita-alla is a code owner

@thomasjpfan thomasjpfan Awaiting requested review from thomasjpfan thomasjpfan will be requested when the pull request is marked ready for review thomasjpfan is a code owner

@Future-Outlier Future-Outlier Awaiting requested review from Future-Outlier Future-Outlier will be requested when the pull request is marked ready for review Future-Outlier is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pryce-turner @flyte-bot